Matter Shell WebSocket #1990
Matter Shell WebSocket #1990
Conversation
…tead of terminal I/O. Incudes a bare-bones webserver to make interaction more convenient
pullapprove
bot
requested review from
Apollon77,
lauckhart,
turon,
vves and
woody-apple
…d description of the capability in the README
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| tile.innerHTML = "<small>Node " + nodeId + "<br><span class=" + | ||
| ((status === "connected") ? "connected-node-status>" : "connecting-node-status>") + status + "</span></small>"; |
Check failure
Code scanning / CodeQL
Client-side cross-site scripting High
…off command UI. Console cleanup.
| [TEMPERATURE]: (value, units = 'F') => { return (units === "F" ? (value / 100 * 9 / 5 + 32) : (value / 100)).toFixed(1) + '°' + units }, | ||
| [PRESSURE]: (value, units = 'mb') => { return (value / 10000).toFixed(1) + units }, | ||
| [HUMIDITY]: (value, units = '%') => { return (value / 100).toFixed(1) + units }, | ||
| } |
Check notice
Code scanning / CodeQL
Semicolon insertion Note
| } | ||
| element.id = `attr-${currentNode}/${currentEndpoint}/${matches[1]}`; | ||
| if (!document.getElementById(`${currentEndpoint}-container-${currentNode}`)) { | ||
| endpointContainer = document.createElement('div'); |
Check warning
Code scanning / CodeQL
Missing variable declaration Warning
| endpointContainer = document.createElement('div'); | ||
| endpointContainer.id = `${currentEndpoint}-container-${currentNode}`; | ||
| endpointContainer.className = 'node-container'; | ||
| endpointContainer.innerHTML = `<small>${currentEndpointType.replace('MA-', '')}<small><br>`; |
Check failure
Code scanning / CodeQL
Client-side cross-site scripting High
| if (matches) { | ||
| if (matches[4] == ON_OFF) styleContainer(matches[1], matches[3], matches[6]); | ||
| else if (matches[4] == ILLUMINANCE || matches[4] == TEMPERATURE || matches[4] == PRESSURE || matches[4] == HUMIDITY || matches[4] == VOLTAGE) { | ||
| const value = valueFormat[matches[4]] ? valueFormat[matches[4]](matches[6]) : matches[6]; |
Check failure
Code scanning / CodeQL
Unvalidated dynamic method call High
| if (matches[4] == ON_OFF) styleContainer(matches[1], matches[3], matches[6]); | ||
| else if (matches[4] == ILLUMINANCE || matches[4] == TEMPERATURE || matches[4] == PRESSURE || matches[4] == HUMIDITY || matches[4] == VOLTAGE) { | ||
| const value = valueFormat[matches[4]] ? valueFormat[matches[4]](matches[6]) : matches[6]; | ||
| document.getElementById(`attr-${matches[1]}/${matches[3]}/${matches[5]}`).innerHTML = `<small>${value}</small>`; |
Check failure
Code scanning / CodeQL
Client-side cross-site scripting High
|
|
||
| matches = message.match(/Attribute value for (\w+) (\d+)\/(\d+)\/(\d+)\/(\w+): (.+)/); // from "read attribute" | ||
| if (matches ) | ||
| if ( matches[1] === "onOff" ) styleContainer(matches[2], matches[3], matches[6]) |
Check notice
Code scanning / CodeQL
Semicolon insertion Note
| matches = message.match(/Attribute value for (\w+) (\d+)\/(\d+)\/(\d+)\/(\w+): (.+)/); // from "read attribute" | ||
| if (matches ) | ||
| if ( matches[1] === "onOff" ) styleContainer(matches[2], matches[3], matches[6]) | ||
| else console.log( `read of ${matches[1]} = ${matches[6]}` ) |
Check notice
Code scanning / CodeQL
Semicolon insertion Note
| matches = message.match(/Attribute value for (\w+) (\d+)\/(\d+)\/(\d+)\/(\w+): (.+)/); // from "read attribute" | ||
| if (matches ) | ||
| if ( matches[1] === "onOff" ) styleContainer(matches[2], matches[3], matches[6]) | ||
| else console.log( `read of ${matches[1]} = ${matches[6]}` ) |
Check warning
Code scanning / CodeQL
Log injection Medium
Adding ability for Matter Shell to optionally utilize a WebSock instead of terminal I/O. Incudes a bare-bones web server to make interaction more convenient although using a full-featured web server is recommended. I have an html/javascript controller that utilizes this capability, but it is not included in this PR